Infer dynamic loop bounds from IntegerRangeAnalysis for GPU tile-and-fuse #23448
+160
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YashDeshpande25
force-pushed
the
dynamic_GEMM_TAF
branch
from
19f6438 to
2c51125
Compare
Contributor
nirvedhmeshram
left a comment
nirvedhmeshram
left a comment
There was a problem hiding this comment.
I think the outer logic is what we want, however I think we can largely simplify the logic in getLoopBoundsWithRangeAnalysis by using TensorDynamicDimAnalysis provided in the compiler, you can closely follow BlockDynamicDimensions pass for this.
compiler/src/iree/compiler/Codegen/Dialect/GPU/TargetUtils/ConfigUtils.cpp
Outdated
Show resolved
Hide resolved
YashDeshpande25
force-pushed
the
dynamic_GEMM_TAF
branch
5 times, most recently
from
854b90c to
8e985d1
Compare
| getLoopBoundsWithRangeAnalysis(linalgOp, entryPoint); | ||
| SmallVector<int64_t> bounds; | ||
| if (succeeded(maybeBounds)) { | ||
| boundsUsingAnalysis = true; |
Contributor
There was a problem hiding this comment.
I think this bool will be set true even when the bounds you find are equal to the bounds of getStaticLoopRanges, but what we want is to only set this to true if you are making bounds that are different from the bounds of getStaticLoopRanges.
compiler/src/iree/compiler/Codegen/Dialect/GPU/TargetUtils/ConfigUtils.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/TargetUtils/ConfigUtils.cpp
Outdated
Show resolved
Hide resolved
YashDeshpande25
force-pushed
the
dynamic_GEMM_TAF
branch
3 times, most recently
from
d1b18ea to
9e9cf26
Compare
…erRangeAnalysis in TAF Signed-off-by: Yash Deshpande <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added function to determine bounds of dynamic dims in GEMMs using InterRangeAnalysis in Tile & Fuse Pipeline.